fix: use _peerConnectionId for accurate volume tracking#228
Merged
davidliu merged 4 commits intolivekit:mainfrom Apr 8, 2025
Merged
fix: use _peerConnectionId for accurate volume tracking#228davidliu merged 4 commits intolivekit:mainfrom
davidliu merged 4 commits intolivekit:mainfrom
Conversation
The current implementation uses mediaStreamTrack.peerConnectionId, which is undefined in certain platforms. This PR fixes the issue by accessing the internal _peerConnectionId property. Though private, this is necessary for consistent behavior and avoids a silent failure in the volume processor. Tested and verified to resolve the issue.
The current implementation uses mediaStreamTrack.peerConnectionId, which is undefined in certain platforms. This PR fixes the issue by accessing the internal _peerConnectionId property. Though private, this is necessary for consistent behavior and avoids a silent failure in the volume processor. Tested and verified to resolve the issue. Issue I faced From: https://livekit-users.slack.com/archives/C07FVFGAUKX/p1743737909092499
|
|
davidliu
reviewed
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation uses mediaStreamTrack.peerConnectionId, which is undefined in certain platforms. This PR fixes the issue by accessing the internal _peerConnectionId property. Though private, this is necessary for consistent behavior and avoids a silent failure in the volume processor. Tested and verified to resolve the issue.
Faced Issue :
https://livekit-users.slack.com/archives/C07FVFGAUKX/p1743737909092499
Now solved